Skip to content

introduce CODEOWNERS, align service names with specs #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2025

Conversation

alexrashed
Copy link
Member

Motivation

In our previous docs repo, we did use a partly auto-generated CODEOWNERS file to assign reviewers for changes to the docs.
This automation is based on the official AWS service abbreviations to associate the services with the files in the repo.
This PR renames some files which did not align to this convention yet (as you can see in this folder in the botocore repo), and then introduces a (mostly) auto-generated CODEOWNERS file.

Changes

  • Renames the following files:
    • pca.mdx -> acm-pca.mdx
    • appautoscaling.mdx -> application-autoscaling.mdx
    • iotdata.mdx -> iot-data.mdx
    • msk.mdx -> kafka.mdx
    • cloudwatchlogs.mdx -> logs.mdx
    • elementalmediaconvert.mdx-> mediaconvert.mdx
    • resourcegroups.mdx -> resource-groups.mdx
    • cognito.mdx -> cognito-idp.mdx
    • timestream.mdx-> timestream-query.mdx
  • Introduces a new CODEOWNERS file where:

@alexrashed alexrashed added the enhancement New feature or request label Jul 14, 2025
@quetzalliwrites
Copy link
Collaborator

Thank you for your proactive work here @alexrashed 🙌🏻 🫶

@quetzalliwrites
Copy link
Collaborator

@HarshCasper as we already noted in Slack, let me know if you need my support to fix the broken redirects links issue that is causing the failed build.

@alexrashed
Copy link
Member Author

FYI: Changing the state to draft, since @HarshCasper mentioned that for this PR we first need to fix our redirects first (public/_redirects).
@HarshCasper: As discussed I'll leave this to you, please let me know if there's anything I can do to help.

@alexrashed alexrashed marked this pull request as draft July 15, 2025 06:22
@HarshCasper HarshCasper marked this pull request as ready for review July 24, 2025 16:52
Copy link

cloudflare-workers-and-pages bot commented Jul 24, 2025

Deploying localstack-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ee5034b
Status: ✅  Deploy successful!
Preview URL: https://155a92c5.localstack-docs.pages.dev
Branch Preview URL: https://automated-codeowners.localstack-docs.pages.dev

View logs

@quetzalliwrites quetzalliwrites merged commit a265605 into master Jul 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants